Skip to content

Solution#998

Open
ExtymAndriy wants to merge 15 commits into
mate-academy:masterfrom
ExtymAndriy:develop
Open

Solution#998
ExtymAndriy wants to merge 15 commits into
mate-academy:masterfrom
ExtymAndriy:develop

Conversation

@ExtymAndriy
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but you need to share your working DEMO LINK and pass all linter checks before requesting mentor's review

@ExtymAndriy
Copy link
Copy Markdown
Author

@ExtymAndriy ExtymAndriy requested a review from brespect May 20, 2026 19:04
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, let's start from Detail Page:

  1. Bread Crumbs icon is broken:
Image
  1. Why use should see the ID here?
Image
  1. Buttons are not aligned to left side and favourite icon is brroken:
Image
  1. This section looks completely different from the mockup, let's check Figma:
Image
  1. Cards in slider should be full view, not cropped:
Image
  1. Header should be same color as background:
Image

@ExtymAndriy
Copy link
Copy Markdown
Author

@ExtymAndriy ExtymAndriy requested a review from brespect May 21, 2026 12:38
Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👏

here are some improvements:

  1. content container should be the same width for all sections
Image
  1. it would be great if all images were +- the same sized
Image
  1. image looks broken
Image
  1. it will be great if user can delete item from cart by clicking there
Image
  1. fix images
Image Image
  1. footer should always be on the screen bottom
Image
  1. change favicon and title
Image
  1. fix layout inside cart
Image
  1. add total items count and take a look at amount in your header
Image
  1. implement some functionality for this button
Image

@ExtymAndriy ExtymAndriy requested a review from 2pasha May 22, 2026 15:14
Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!

  1. When User selects any sorting parameters, they should appear in the URL as Search Params
Image
  1. Most of issues from prev mentor review did not fixed yet (favicon, non-existing icons, footer positioning etc.). Fix all of them, double-check is everything looks fine and then re-request review again
Image

@ExtymAndriy
Copy link
Copy Markdown
Author

https://extymandriy.github.io/react_phone-catalog/

З якоїсь причини не всі зображення хочуть з'являтися одразу тому потрібно оновити сторінку і все буде працювати

Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove this horizontal scroll:
Image
  1. Cart page has a huge diff with Figma mockup:
Image
  1. Implement Checkout button functional. Just add a notification (e.g. "Thank for you order!") and wipe all cart state. You can use [this link](https://react-phone-catalog-chi.vercel.app/) as a reference

  2. Back to Top button doesn't work as expected

@ExtymAndriy
Copy link
Copy Markdown
Author

Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. It's better to export logos and icons in .svg format from Figma for better quality
Image Image
  1. On desktop there should be 4 cards in a row
Image
  1. On slider it's better to adjust it according to design (on tablet should be 2.5 cards visible)
Image Image
  1. There is a bug with displaying cards (there is also needed to align it with design)
Image Image
  1. On phone there should be only one card visible in slider
Image
  1. Icons aren't loaded for phone's menu.
Image
  1. On phone the slider goes outside the page
Image Image
  1. I would recommend to disable scrolling when menu is open

  2. It's better to adjust phone's page according to design and content goes outside

Image Image
  1. It's better to add favicon for website
Image

If you have any questions about the project - feel free to ask them in chat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants