Solution#998
Conversation
brespect
left a comment
There was a problem hiding this comment.
Good progress, but you need to share your working DEMO LINK and pass all linter checks before requesting mentor's review
brespect
left a comment
There was a problem hiding this comment.
Good progress, let's start from Detail Page:
- Bread Crumbs icon is broken:
- Why use should see the ID here?
- Buttons are not aligned to left side and favourite icon is brroken:
- This section looks completely different from the mockup, let's check Figma:
- Cards in slider should be full view, not cropped:
- Header should be same color as background:
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements:
- content container should be the same width for all sections
- it would be great if all images were +- the same sized
- image looks broken
- it will be great if user can delete item from cart by clicking there
- fix images
- footer should always be on the screen bottom
- change favicon and title
- fix layout inside cart
- add total items count and take a look at amount in your header
- implement some functionality for this button
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Almost done!
- When User selects any sorting parameters, they should appear in the URL as Search Params
- Most of issues from prev mentor review did not fixed yet (favicon, non-existing icons, footer positioning etc.). Fix all of them, double-check is everything looks fine and then re-request review again
|
https://extymandriy.github.io/react_phone-catalog/ З якоїсь причини не всі зображення хочуть з'являтися одразу тому потрібно оновити сторінку і все буде працювати |
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
- Remove this horizontal scroll:
- Cart page has a huge diff with Figma mockup:
-
Implement
Checkoutbutton functional. Just add a notification (e.g. "Thank for you order!") and wipe all cart state. You can use[this link](https://react-phone-catalog-chi.vercel.app/)as a reference -
Back to Topbutton doesn't work as expected
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
A few things to improve:
- It's better to export logos and icons in
.svgformat from Figma for better quality
- On desktop there should be 4 cards in a row
- On slider it's better to adjust it according to design (on tablet should be 2.5 cards visible)
- There is a bug with displaying cards (there is also needed to align it with design)
- On phone there should be only one card visible in slider
- Icons aren't loaded for phone's menu.
- On phone the slider goes outside the page
-
I would recommend to disable scrolling when menu is open
-
It's better to adjust phone's page according to design and content goes outside
- It's better to add favicon for website
If you have any questions about the project - feel free to ask them in chat
No description provided.